fix: Replace Rollup with Webpack for client JS bundling #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two main reasons: - It's much easier to _make sure_ `PercyAgent` is being set on the `window` object. - Our tests use webpack (because rollup is hard for that), so it makes sense to match prod with what we're bundling in tests
Robdel12
changed the title
djones
pushed a commit
that referenced
this pull request
Jun 13, 2019
## [0.7.1](v0.7.0...v0.7.1) (2019-06-13) ### Bug Fixes * Replace Rollup with Webpack for client JS bundling ([#249](#249)) ([450c31e](450c31e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
The problem here is it's hard to get rollup to export our PercyAgent JS as a global on the
windowobject. We addedextend: trueto the rollup config in #178 and thought that was the final fix. I wasn't thrilled that the compiled JS ended up beingthis.PercyAgent = ...., but it was good enough.That is, until today. I was debugging snapshotting issues with a customer using the Capybara SDK. When we logged
thisfrom thedriver.execute_scriptmethod, it returned a different library (Rollbar!!) and not thewindowobject like we assume.This PR replaces Rollup with Webpack because it's very easy to export directly to the
windowobject. It also makes our testing more reliable since our test setup was using Webpack too. This now means our tests and prod code are being transpiled & bundled the same way.TL;DR: We go from this:
To this: