fix: Expose PercyAgent as a global always
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second time is the charm right? We're going to beta test this one but it should do it. Setting `extend: true` in the rollup config allows the bundler to extend the global namespace (window). So the output now looks like `this.PercyAgent = ` (where `this` is the window object)
djones
pushed a commit
that referenced
this pull request
May 3, 2019
## [0.4.4](v0.4.3...v0.4.4) (2019-05-03) ### Bug Fixes * Expose `PercyAgent` as a global always ([#178](#178)) ([698067b](698067b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Second time is the charm right? Setting
extend: truein the rollup config allowsthe bundler to extend the global namespace (window).
So, the output now looks like
this.PercyAgent =(wherethisis thewindow object)
I cut a beta release of this and tested it on the various SDKs (btw, we need a better process for this):
This one should do the trick 👍