Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert & remove browser from package.json #123

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Apr 3, 2019

What is this?

Looks like we need to also introduce rollup to bunndle all of the files together into a single file when we introduce the browser field. Otherwise bundlers are going to fall over at the bad require file paths.

Looks like we need to also introduce rollup to bunndle all of the
files together into a single file when we introduce the `browser`
field. Otherwise bundlers are going to fall over at the bad `require`
file paths
@Robdel12 Robdel12 requested a review from djones April 3, 2019 23:04
Copy link
Contributor

@djones djones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

@Robdel12 Robdel12 merged commit 06afbf0 into master Apr 3, 2019
@Robdel12 Robdel12 deleted the rd/revert-browser-field branch April 3, 2019 23:07
Robdel12 added a commit that referenced this pull request Apr 3, 2019
Looks like we need to also introduce rollup to bunndle all of the
files together into a single file when we introduce the `browser`
field. Otherwise bundlers are going to fall over at the bad `require`
file paths
djones pushed a commit that referenced this pull request Apr 3, 2019
## [0.2.1](v0.2.0...v0.2.1) (2019-04-03)

### Bug Fixes

* Revert & remove `browser` from `package.json` ([#123](#123)) ([994f2ad](994f2ad))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants