feat: Add hidden snapshot command for future implementation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maprules1000
force-pushed
the
map/static-site-support
branch
from
d024767
to
7987a09
Compare
maprules1000
commented
Apr 10, 2019
maprules1000
force-pushed
the
map/static-site-support
branch
from
7987a09
to
73aa318
Compare
maprules1000
force-pushed
the
map/static-site-support
branch
from
73aa318
to
5de524c
Compare
|
This PR is a stepping stone to #132 which will implement and test the underlying static snapshot service |
Robdel12
reviewed
Apr 12, 2019
| import logger from '../utils/logger' | ||
| import {StaticSnapshotOptions} from './static-snapshot-options' | ||
|
|
||
| export default class StaticSnapshotService { |
There was a problem hiding this comment.
As I read through this, I wonder if it would make sense to have the snapshot service extend the agent service? Or at least take care of the setup of the agent service in this constructor, so you don't have to do that in the run command method
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 12, 2019
maprules1000
changed the title
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 12, 2019
djones
reviewed
Apr 13, 2019
| @@ -1,5 +1,6 @@ | |||
| export default class Constants { | |||
| static readonly PORT: number = 5338 | |||
| static readonly NETWORK_IDLE_TIMEOUT: number = 50 // in milliseconds | |||
djones
reviewed
Apr 13, 2019
djones
reviewed
Apr 15, 2019
djones
reviewed
Apr 15, 2019
djones
reviewed
Apr 15, 2019
djones
reviewed
Apr 15, 2019
djones
reviewed
Apr 15, 2019
djones
suggested changes
Apr 16, 2019
maprules1000
force-pushed
the
map/static-site-support
branch
from
8181cf7
to
07d3e5a
Compare
timhaines
reviewed
Apr 16, 2019
djones
pushed a commit
that referenced
this pull request
Apr 16, 2019
# [0.3.0](v0.2.3...v0.3.0) (2019-04-16) ### Features * Add hidden snapshot command for future implementation ([#120](#120)) ([98ae4b8](98ae4b8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a hidden snapshot command, and a stubbed static snapshot service that will be fleshed out in a future PR.
This also includes tests for the snapshot command.