Skip to content

Commit

Permalink
feat: Use node v10 (#467)
Browse files Browse the repository at this point in the history
_Potentially breaking release_, so tagged as a feature in case users need to pin
to an older version rather than update unmaintained node
  • Loading branch information
Wil Wilsman authored Feb 3, 2020
1 parent e4ac517 commit 920868f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ jobs:
command: export PERCY_ENABLE=0
- cli_integration
- store_artifacts
node-8:
node-12:
<<: *test_config
docker:
- image: circleci/node:8-browsers
- image: circleci/node:12-browsers
steps:
- setup
- cli_commands
Expand All @@ -91,15 +91,15 @@ jobs:
finalize_percy:
<<: *test_config
docker:
- image: circleci/node:8-browsers
- image: circleci/node:12-browsers
steps:
- checkout
- run: yarn && yarn build
- run: ./bin/run finalize --all
release:
<<: *test_config
docker:
- image: circleci/node:8-browsers
- image: circleci/node:12-browsers
steps:
- checkout
- run: yarn
Expand All @@ -110,16 +110,16 @@ workflows:
default:
jobs:
- node-10
- node-8
- node-12
- finalize_percy:
requires:
- node-10
- node-8
- node-12
- release:
filters:
branches:
only:
- master
requires:
- node-10
- node-8
- node-12
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"webpack-cli": "^3.3.4"
},
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"files": [
".oclif.manifest.json",
Expand Down

0 comments on commit 920868f

Please sign in to comment.