fix(🐛): Skip all response caches when response caching is disabled (#537

)

* fix(🐛): Skip all response caches when response caching is disabled

* 🏷️ Add useless type to satisfy the compiler

src/services/asset-discovery-service.ts

@@ -25,8 +25,15 @@ export class AssetDiscoveryService extends PercyClientService {
     super()
     this.browser = null
     this.pagePool = null
-    this.configuration = configuration || DEFAULT_CONFIGURATION.agent['asset-discovery']
-    this.responseService = new ResponseService(buildId, this.configuration['allowed-hostnames'])
+
+    this.configuration = configuration ||
+      DEFAULT_CONFIGURATION.agent['asset-discovery']
+
+    this.responseService = new ResponseService(
+      buildId,
+      this.configuration['allowed-hostnames'],
+      this.configuration['cache-responses']
+    )
   }
 
   async setup() {

src/services/response-service.ts

@@ -20,11 +20,13 @@ export default class ResponseService extends PercyClientService {
   resourceService: ResourceService
   responsesProcessed: Map<string, string> = new Map()
   allowedHostnames: string[]
+  cacheResponses: boolean
 
-  constructor(buildId: number, allowedHostnames: string[]) {
+  constructor(buildId: number, allowedHostnames: string[], cacheResponses: boolean) {
     super()
     this.resourceService = new ResourceService(buildId)
     this.allowedHostnames = allowedHostnames
+    this.cacheResponses = cacheResponses
   }
 
   shouldCaptureResource(rootUrl: string, resourceUrl: string): boolean {
@@ -51,9 +53,9 @@ export default class ResponseService extends PercyClientService {
     logger.debug(addLogDate(`processing response: ${response.url()} for width: ${width}`))
     const url = this.parseRequestPath(response.url())
 
-    // skip responses already processed
+    // skip responses already processed unless the response cache is disabled
     const processResponse = this.responsesProcessed.get(url)
-    if (processResponse) { return processResponse }
+    if (this.cacheResponses && processResponse) { return processResponse }
 
     const request = response.request()
     const parsedRootResourceUrl = new URL(rootResourceUrl)