Skip to content

Commit

Permalink
feat: Enable asset discovery network caching by default (#469)
Browse files Browse the repository at this point in the history
We have tried this out in support for the past couple months with _great_
success. We're confident enough in this approach to now enable it by default for
evveryone, which should make the asset discovery process much more reliable and faster.
  • Loading branch information
Robdel12 authored Feb 28, 2020
1 parent c2ac0cf commit 6b36aab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/commands/exec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default class Exec extends PercyCommand {
'cache-responses': flags.boolean({
description: [
`[default: ${DEFAULT_CONFIGURATION.agent['asset-discovery']['cache-responses']}]`,
'Enable caching network responses for asset discovery (experimental)',
'Caches successful network responses in asset discovery',
].join(' '),
}),
'port': flags.integer({
Expand Down
2 changes: 1 addition & 1 deletion src/configuration/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const DEFAULT_CONFIGURATION: Configuration = {
'network-idle-timeout': 50, // ms
'page-pool-size-min': 1, // pages
'page-pool-size-max': 5, // pages
'cache-responses': false,
'cache-responses': true,
},
},
'static-snapshots': {
Expand Down

0 comments on commit 6b36aab

Please sign in to comment.