-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cppcheck workflow #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemgavrilov
changed the title
Upgrade ubuntu from 20.04 to 22.04
Fix cppcheck workflow
Apr 3, 2024
artemgavrilov
commented
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 90.55% 90.56%
=======================================
Files 3 3
Lines 1271 1272 +1
Branches 35 35
=======================================
+ Hits 1151 1152 +1
Misses 98 98
Partials 22 22 ☔ View full report in Codecov by Sentry. |
artemgavrilov
requested review from
Naeem-Akhter,
dutow,
codeforall and
dAdAbird
April 3, 2024 12:50
Naeem-Akhter
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dAdAbird
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppcheck
version available in ubuntu repos is pretty old.cppcheck
doesn't provide pre-build binaries, so it looks like the best option to get fresh version is to build it from sources. Version that we used had some bugs that were fixed in recent releases, so just updating it healed workflow.