Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cppcheck workflow #441

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Fix cppcheck workflow #441

merged 8 commits into from
Apr 5, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Apr 2, 2024

cppcheck version available in ubuntu repos is pretty old. cppcheck doesn't provide pre-build binaries, so it looks like the best option to get fresh version is to build it from sources. Version that we used had some bugs that were fixed in recent releases, so just updating it healed workflow.

@artemgavrilov artemgavrilov changed the title Upgrade ubuntu from 20.04 to 22.04 Fix cppcheck workflow Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (3d84610) to head (1f74693).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   90.55%   90.56%           
=======================================
  Files           3        3           
  Lines        1271     1272    +1     
  Branches       35       35           
=======================================
+ Hits         1151     1152    +1     
  Misses         98       98           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review April 3, 2024 12:50
Copy link
Contributor

@Naeem-Akhter Naeem-Akhter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@artemgavrilov artemgavrilov merged commit 684e648 into main Apr 5, 2024
13 of 24 checks passed
@artemgavrilov artemgavrilov deleted the fix-cppcheck branch April 5, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants