Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socialaccount): Fix SocialLogin.is_existing always False when sig… #3921

Closed
wants to merge 2 commits into from
Closed

fix(socialaccount): Fix SocialLogin.is_existing always False when sig… #3921

wants to merge 2 commits into from

Conversation

juchajam
Copy link
Contributor

@juchajam juchajam commented Jun 26, 2024 •
edited
Loading

Fix SocialLogin.is_existing always False when signup.
fix #3870

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

@coveralls
Copy link

Coverage Status

coverage: 95.745%. remained the same
when pulling 348b14a on juchajam:main
into 4746fb5 on pennersr:main.

@coveralls
Copy link

Coverage Status

coverage: 95.74% (-0.005%) from 95.745%
when pulling 6718e89 on juchajam:main
into 4746fb5 on pennersr:main.

@pennersr
Copy link
Owner

See: #3870 (comment)

The idea behind that is not None is to cache the result. This is working perfectly fine, but apparently breaks when projects are completely bypassing the allauth pipelines, which they really should not be doing.

@pennersr pennersr closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_existing not updating after saving a new user connected to SocialLogin
3 participants
@juchajam @coveralls @pennersr