umpf: fix losing flags while continue #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'umpf continue' case was tested only with the use-case where flags
are specified via the cmdline. If flags are provided via an useries file
they are still lost. Fix this by making use of the new flags status
file while bailout(). This file is always generated.
This commit also fixes the case the following case: flags were succefull
verified but umpf fails later on e.g. during a tag run and we would need
to run 'umpf continue'. In such case they are marked within the
${STATE}/done file so the hooks are not executed again. Fix this by
checking for the FLAGS cmdline parameter or the new ${STATE}/flags file
to parse and setup the flags everytime.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Emantor
approved these changes
Dec 7, 2023
|
Fixed differently in #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'umpf continue' case was tested only with the use-case where flags are specified via the cmdline. If flags are provided via an useries file they are still lost. Fix this by making use of the new flags status file while bailout(). This file is always generated.
This commit also fixes the case the following case: flags were succefull verified but umpf fails later on e.g. during a tag run and we would need to run 'umpf continue'. In such case they are marked within the ${STATE}/done file so the hooks are not executed again. Fix this by checking for the FLAGS cmdline parameter or the new ${STATE}/flags file to parse and setup the flags everytime.