Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row data type #60

Open
tpisto opened this issue Jul 7, 2023 · 2 comments
Open

Row data type #60

tpisto opened this issue Jul 7, 2023 · 2 comments

Comments

@tpisto
Copy link
Contributor

tpisto commented Jul 7, 2023

This is more of a question than an issue. Have you planned to use generic row data type instead of String?

pub struct Row<T> {
    pub id: RowID,
    pub data: T,
}

I tried to implement the Row in my fork (https://github.com/tpisto/tihku) and it's mostly working, tests are passing, etc. But the self.rows.remove(&id) gives a lifetime issue I have not yet managed to solve... If Row is in your interest, maybe you could have better insight what's wrong the lifetime there.

ps. congrats for the cool project 👍🏻

@tpisto
Copy link
Contributor Author

tpisto commented Jul 8, 2023

I added 'static bounds to T, and everything works now in my fork.

'static bound is known limitation of skiplist and could be removed in the future.
crossbeam-rs/crossbeam#205

@penberg
Copy link
Owner

penberg commented Jul 8, 2023

@tpisto Haha, yes, we've just been to lazy to do this. If you got the lifetime issues sorted out, can you please open a pull request? I think I will need @psarna to review it because he's was the one doing the switch to lockless skip list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants