Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Compatibility with secrets.yaml #18

Open
Ninja1283 opened this issue Jul 28, 2021 · 4 comments
Open

Feature Request: Compatibility with secrets.yaml #18

Ninja1283 opened this issue Jul 28, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@Ninja1283
Copy link

Somewhat related to #8, are you able to add compatibility with the Home Assistant secrets file to avoid having plaintext credentials stored in the config?

@deviantintegral
Copy link
Collaborator

To do that, I think we'd need to parse the secrets.yaml file (with python?), but then we'd end up having to write them back out to disk (following the work at #14). Or, we'd have to use the -F option instead when starting the process (as it does look like rtl_433 excludes the username and password settings from the process listing).

@deviantintegral
Copy link
Collaborator

We no longer require secrets to be stored in the config, as long as you're using the MQTT broker within Home Assistant. Does that solve this need for you?

@Ninja1283
Copy link
Author

Ninja1283 commented Jan 15, 2022

We no longer require secrets to be stored in the config, as long as you're using the MQTT broker within Home Assistant. Does that solve this need for you?

The main addon documentation still says that "the absolute minimum that you need to specify in the config file is the MQTT connection and authentication information: output mqtt://HOST:PORT,user=XXXX,pass=YYYYYYY"

Is that not still the case?

Additionally, for people using auto discovery and an external MQTT server location, plaintext secrets are still stored in the config. I suppose using manually configured entities and/or using the Mosquito broker within HA would be able to eliminate this issue, but there are still some edge-case scenarios to think about.

@deviantintegral
Copy link
Collaborator

No, it's not, and we should improve that text.

and an external MQTT server location

Yes, that's what I was trying to get at - there's no way for us to autodetect those credentials. secrets.yaml would be a nice improvement for those setups, and while I don't expect to prioritize it myself (since I wouldn't use it!) I'm glad to review and test PRs.

@deviantintegral deviantintegral added enhancement New feature or request and removed question Further information is requested labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants