Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovered entities with a name that starts with the device name #152

Open
s992 opened this issue Aug 4, 2023 · 5 comments
Open

Discovered entities with a name that starts with the device name #152

s992 opened this issue Aug 4, 2023 · 5 comments
Labels
needs fix upstream Needs a PR filed at merbanan/rtl_433

Comments

@s992
Copy link

s992 commented Aug 4, 2023

The problem

I'm not entirely sure that this is an issue caused by this addon, so please let me know if I'm posting in the wrong place! :)

With a recent HA upgrade, I started receiving the following warning:

image

In case the image doesn't load or is otherwise not legible, the text is:

Discovered entities with a name that starts with the device name

This stops working in version 2024.2.0. Please address before upgrading.

Some MQTT entities have an entity name that starts with the device name. This is 
not expected. To avoid a duplicate name the device name prefix is stripped of the 
entity name as a work-a-round. Please inform the maintainer of the software 
application that supplies the affected entities to fix this issue.

List of affected entities:

- sensor.acurite_5n1_a_2468_f
- sensor.acurite_5n1_a_2468_ws
- sensor.acurite_5n1_a_2468_rt
- sensor.acurite_5n1_a_2468_wd
- sensor.acurite_5n1_a_2468_h
- sensor.acurite_5n1_a_2468_b

The "Learn More" link links out to https://developers.home-assistant.io/blog/2023-057-21-change-naming-mqtt-entities/.

I'm using this weather station and it's been working fine (and continues to work fine!) for about a year now. I have not integrated any other devices with rtl_433 or MQTT.

Should I be concerned by this warning? Is there anything I can do to resolve it?

What addon are you reporting the bug for?

rtl_433_mqtt_autodiscover

What is the addon version?

0.6.0

What type of MQTT Broker are you using?

Home Assistant Mosquitto MQTT Broker

Addon log messages

No response

Additional information

rtl_433 addon version is 0.4.0
rtl_433 MQTT Auto Discovery addon version is 0.6.0
Mosquitto broker addon version is 6.2.1

@deviantintegral
Copy link
Collaborator

I don't think there's anything for you to worry about right now. The actual breaking change won't kick in until 2024.2.

I just upgraded myself, and it looks like this is triggering for all of my zigbee2mqtt devices too. I will probably wait to see how they solve this before tackling this here.

@deviantintegral
Copy link
Collaborator

Actually, this will need to be fixed in the upstream rtl-433 repository since that's where the autodiscovery script itself lives.

@deviantintegral deviantintegral added the needs fix upstream Needs a PR filed at merbanan/rtl_433 label Aug 5, 2023
@BarryMar
Copy link

This just got fixed in merbanan/rtl_433@9e0fb41

@lindsand
Copy link

lindsand commented Nov 6, 2023

Good to know it's fixed for coming releases (as it's not urgent).

The warning comes from here, device name is repeated is the sensor names:

  • and are now truncated by MQTT to -T (for Temperature) and -B (for Battery) and so on.

image

@deviantintegral
Copy link
Collaborator

I'm leaving this open until merbanan/rtl_433#2652 is resolved and we can point to a new release containing this fix for the stable branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs fix upstream Needs a PR filed at merbanan/rtl_433
Projects
None yet
Development

No branches or pull requests

4 participants