This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Install packages before copying rest of code in Dockerfile template #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile was copying the
package*.json
files, then copying the entire rest of the code, and then installing the dependencies. This defeats the purpose of copyingpackage*.json
first, since the build step cache will be invalidated whenever the code changes.This PR moves the install command above the code copy command.
P.S. I didn't see any contribution guidelines, sorry if this PR does not adhere to a required template.