Excluding stuff

[szepeviktor]

• deprecated code
• compat. code
• views

@paulthewalton How about picking what is unnecessary and releasing it on https://github.com/php-stubs ?

See core and WC finder.php.

[Ciantic]

Yea, this package does not play well with the wordpress stubs, for instance this acf stub should not redeclare:

function determine_locale()
{
}

Now it's unusable in phpstan with WordPress stubs.

[szepeviktor]

It is not so easy as that function has no own file but lives in includes/l10n.php

[paulthewalton]

I've done a bit of this over at acf-pro-stubs, specifically:

• deprecated, views, assets
• determine_locale

I was unsure about not including the compat stuff in advanced-custom-fields-pro\includes\compatibility.php, mostly because I'm still not very familiar with the ACF code base.

Also, i removed determine_locale from the generated stubs file via regex, which can be expanded to include any other functions, but seems a little inelegant if nothing else.

Full disclosure, I'm not currently using PHPStan, I just made this repo to use with Intelephense, so if there are other functions that aren't playing well with PHPStan, I'll happily add them to the list.

[paulthewalton]

Closed the issue by accident. WRT my above comment, I'll be moving some of those changes over to this repo in the next little while.

[szepeviktor]

Okay! Thank you.

[szepeviktor]

determine_locale

Mine is

sed -e '/^function determine_locale()/{N;N;d}' -i acf-stubs-${PLUGIN_VERSION}.php

but it only removes the empty function leaving its docblock there.

[szepeviktor]

Actually the proper solution is to ask @elliotcondon to put it in a separate core-functions.php