Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in the ES WebAssembly build by using the flag -sWASM=0. I initially thought this flag would simply prevent the generation of a WebAssembly binary, but I was wrong. Instead, it embedded everything into a large JavaScript file using wasm2js. In this PR, I removed that flag, and now it generates two WebAssembly files:
Both
pdfium.wasm
andpdfium.esm.wasm
are identical, but thepdfium.esm.js
module links topdfium.esm.wasm
, andpdfium.js
links topdfium.wasm
. I'm not sure if it's currently possible to configureem++
to point to the same file for both, but I think this solution is acceptable for now.