Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs - children prop type updated #168

Closed
nicolethoen opened this issue Dec 8, 2022 · 0 comments · Fixed by #220
Closed

Tabs - children prop type updated #168

nicolethoen opened this issue Dec 8, 2022 · 0 comments · Fixed by #220
Assignees
@wise-king-sullyman
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone
2023.01

Comments

@nicolethoen
Copy link
Contributor

Follow up to breaking change PR patternfly/patternfly-react#8217

Anyone using the Tabs component, we need to warn them that the type of the children prop has been updated from React.ReactNode (which was documented to need to be actually Must be React.ReactElement<TabProps>[]) to now be TabsChild | TabsChild[] (which is now documented to mean the same as Only 'Tab' components or expressions resulting in a falsy value)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod pf5 codemod for p4 to p5 transition
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
3 participants
@gitdallas @wise-king-sullyman @nicolethoen