Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - enhance the examples available on the newly promoted Select Next implementation #8874

Closed
11 tasks
Tracked by #42
mcarrano opened this issue Mar 28, 2023 · 0 comments · Fixed by #8992
Closed
11 tasks
Tracked by #42

Comments

@mcarrano
Copy link
Member

mcarrano commented Mar 28, 2023

In order to better show parity between the new/next Select that is being promoted for PatternFly 5, we should enhance the examples available.

In the new Select examples

  • Single select: Include a disabled state (using a checkbox control or a second Select side by side)
  • Add 'Menu option variations' example. Using one Select with multiple SelectOptions, demonstrate:
    • With description
    • Link
    • With icon
    • Disabled
    • Aria disabled with tooltip
    • include a note to see Menu examples for more variants
  • Grouped single: add divider between groups
  • Add 'View more' example like the deprecated select
  • Add 'With a footer' example like the deprecated select
  • Add 'Typeahead with creatable options' example
    • Make sure it replicates onCreateOption to persist new options to menu
  • Rename the 'Multiple typeahead' example to 'Multiple typeahead with chips'
  • Add 'Multiple typeahead with creatable options' example
    • Make sure it replicates onCreateOption to persist new options to menu
  • Add 'Multiple typeahead with checkbox menu items' example

Also

  • Need to define a PopperProps type to be used by the Select component and exposed on Select page
  • Any menu/MenuItem props not exposed in the Select should be added to select docs (i.e. any props spread to the menu/menuitem components)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants