Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add mediapipe face detector #29

Merged
merged 3 commits into from
May 5, 2023

Conversation

jinwonkim93
Copy link
Contributor

Support mediapipe face detector.
modified to support PIL Image.
credit to https://github.com/Mikubill/sd-webui-controlnet/tree/main/annotator/mediapipe_face

setup.py Outdated
@@ -89,7 +89,8 @@
"einops",
"timm",
"torchvision",
"scikit-image"
"scikit-image",
"mediapipe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the protobuf dependency here: https://github.com/google/mediapipe/blob/a6c35e9ba5b7b877b8d907d0bf5b5c09d8dab6f3/requirements.txt#L7 => this could mess up other installs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it would be better user to install mediapipe by their own. I will remove this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jinwonkim93 jinwonkim93 mentioned this pull request Apr 25, 2023
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants