Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Horqrux GPSR for 2nd order derivatives #468

Closed
dominikandreasseitz opened this issue Jun 18, 2024 · 6 comments
Closed

[Bug] Horqrux GPSR for 2nd order derivatives #468

dominikandreasseitz opened this issue Jun 18, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@dominikandreasseitz
Copy link
Collaborator

cc @atiyo

@dominikandreasseitz dominikandreasseitz self-assigned this Jun 18, 2024
@rajaiitp
Copy link
Collaborator

Random question/thought. In GPSR we compute the coefficients that scale the eigenvalue spectrum differences using a set of random shifts. It seems like these are the same coefficients used for higher order derivatives, with higher powers of shifts. Does it mean that we get all the higher order derivatives for free once we compute these coefficients. Am I missing out something

@atiyo
Copy link
Collaborator

atiyo commented Jul 22, 2024

This should come relatively easily with the correct jacobinan-vector product implementation, which I think is already in qadence. We can bring it over.

Random question/thought. In GPSR we compute the coefficients that scale the eigenvalue spectrum differences using a set of random shifts. It seems like these are the same coefficients used for higher order derivatives, with higher powers of shifts. Does it mean that we get all the higher order derivatives for free once we compute these coefficients. Am I missing out something

We should chat about this! Probably internally so we can back and forth about it a bit easier.

@Roland-djee Roland-djee added the bug Something isn't working label Jul 22, 2024
@Roland-djee
Copy link
Collaborator

Hiya @atiyo would you be able to take that on ? (Also tagging @gvelikova)

@atiyo
Copy link
Collaborator

atiyo commented Jul 22, 2024

Happy to take this on. Not sure what the bug is, though 🤷.

The plan is to take the GPSR implementation out of qadence and put it directly in horqrux---qadence doesn't feel like the right place to implement horqrux functionality. AFAICT, moving it horqrux will also be seamless from the perspective of an end user since it hooks directly into jax's AD either way.

Are we happy to close this issue and raise a corresponding one in horqrux?

@Roland-djee
Copy link
Collaborator

Happy to take this on. Not sure what the bug is, though 🤷.

The plan is to take the GPSR implementation out of qadence and put it directly in horqrux---qadence doesn't feel like the right place to implement horqrux functionality. AFAICT, moving it horqrux will also be seamless from the perspective of an end user since it hooks directly into jax's AD either way.

Are we happy to close this issue and raise a corresponding one in horqrux?

Indeed. I don't think this is a bug rather than a feature (but aren't they the same ? 😬 ) and agreed it can move to Horqrux board. Thanks @atiyo.

@atiyo
Copy link
Collaborator

atiyo commented Jul 23, 2024

Nice. In that case I'm closing this issue since it's covered by this one: pasqal-io/horqrux#22

@atiyo atiyo closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants