Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation error when a node will contains samples from only one class (sklearn) #283

Closed
tlapusan opened this issue Apr 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tlapusan
Copy link
Collaborator

tlapusan commented Apr 2, 2023

Since version 0.19 (which is a pretty old one..) , the min_impurity_decrease defaults to 0.0, which means that we can have split nodes (pure nodes) with samples belonging to only one class.
Ex.
Screenshot 2023-04-02 at 12 31 14

In this scenario, the actual code will fails for hist, bins, barcontainers = ax.hist(X_hist,.... because for a node with samples from only one class will return a Rectangle instead of a list of BarContainer.

@tlapusan tlapusan self-assigned this Apr 2, 2023
@parrt parrt added the bug Something isn't working label Apr 2, 2023
@parrt parrt added this to the 2.2.1 milestone Apr 2, 2023
@parrt parrt closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants