Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class name font could not change #145

Closed
HidenariUoi opened this issue May 24, 2021 · 3 comments
Closed

class name font could not change #145

HidenariUoi opened this issue May 24, 2021 · 3 comments
Labels
bug Something isn't working
Milestone
2.1

Comments

@HidenariUoi
Copy link

I want to change the fontname below.
But, only class name font could not change.

viz = dtreeviz(
clf,
iris.data,
iris.target,
target_name='variety',
feature_names=iris.feature_names,
class_names=iris.target_name ,
fontname='IPAPGothic'
)

I think draw_pichart method in tree.py does not get new fontname.
https://github.com/parrt/dtreeviz/blob/master/dtreeviz/trees.py#L1061
@mepland
Copy link
Collaborator

mepland commented Dec 30, 2022

@parrt this should be resolved now.

@parrt
Copy link
Owner

parrt commented Dec 30, 2022

Fixed by #224 ? @mepland

@parrt parrt added the bug Something isn't working label Dec 30, 2022
@parrt parrt added this to the 2.1 milestone Dec 30, 2022
@mepland
Copy link
Collaborator

mepland commented Dec 31, 2022

@parrt should be!

@parrt parrt closed this as completed Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@parrt @mepland @HidenariUoi