Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Protect/Warn Against Validity Periods That Are Too Long #133

Open
joepetrowski opened this issue May 10, 2020 · 2 comments
Open

Protect/Warn Against Validity Periods That Are Too Long #133

joepetrowski opened this issue May 10, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@joepetrowski
Copy link
Collaborator

After this PR, BlockHashCount should be exposed in the metadata. This is the maximum validity period in blocks. There should be some check, like:

if BlockHashCount in metadata {
    // ensure validityPeriod < BlockHashCount
} else {
    // log "Warning: maximum validity period unknown for this chain..."
}
@joepetrowski joepetrowski added the enhancement New feature or request label May 10, 2020
@amaury1093 amaury1093 self-assigned this May 11, 2020
@emostov
Copy link
Contributor

emostov commented Nov 20, 2020

@joepetrowski is this still relevant to anything txwrapper{-*}?

@joepetrowski
Copy link
Collaborator Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants