Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement code substitutes #1110

Open
tomaka opened this issue Aug 9, 2021 · 2 comments
Open

Properly implement code substitutes #1110

tomaka opened this issue Aug 9, 2021 · 2 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Aug 9, 2021

cc #960

https://github.com/paritytech/smoldot/blob/41c5d164cb36436ce949d51ffb8ca7b49b2addd9/src/chain_spec/structs.rs

image
@tomaka
Copy link
Contributor Author

tomaka commented Aug 11, 2021

This feature conflicts with warp syncing. It is possible to warp sync over the block specified in a codeSubstitutes, and not be aware that a substitution needs to take place.

@tomaka tomaka mentioned this issue Aug 22, 2021
Closed
This was referenced Sep 20, 2021
Merged
Closed
@tomaka
Copy link
Contributor Author

tomaka commented Jun 20, 2022 •
edited
Loading

This feature conflicts with warp syncing. It is possible to warp sync over the block specified in a codeSubstitutes, and not be aware that a substitution needs to take place.

This is no longer a problem after paritytech/substrate#10600 / #1869

@tomaka tomaka mentioned this issue Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka