Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Polkadot's XCM config should use WeightInfoBound weigher #6785

Closed
KiChjang opened this issue Feb 25, 2023 · 3 comments
Closed

Polkadot's XCM config should use WeightInfoBound weigher #6785

KiChjang opened this issue Feb 25, 2023 · 3 comments
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@KiChjang
Copy link
Contributor

KiChjang commented Feb 25, 2023

Currently, the Polkadot XCM config uses FixedWeightBounds as the weigher:

type Weigher = FixedWeightBounds<BaseXcmWeight, RuntimeCall, MaxInstructions>;

I don't think there is a good reason for this other than oversight, especially when Kusama, Rococo and Westend all have WeightInfoBounds as their weigher.

We should thus change the Polkadot XCM config to use WeightInfoBounds. Doing so requires benchmarking XCM instructions on the Polkadot runtime to get benchmark-weighted values for each instruction's weight.

File: runtime/polkadot/src/xcm_config.rs

@KiChjang KiChjang added the T6-XCM This PR/Issue is related to XCM. label Feb 25, 2023
@xlc
Copy link
Contributor

xlc commented Apr 13, 2023

Why this isn't implemented?

@franciscoaguirre
Copy link
Contributor

I can take this

@KiChjang
Copy link
Contributor Author

Should be fixed by #7077.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

3 participants