Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paritypr/polkadot-debug: Fails to start on versi #1197

Closed
alexggh opened this issue Aug 28, 2023 · 2 comments · Fixed by #1198
Closed

paritypr/polkadot-debug: Fails to start on versi #1197

alexggh opened this issue Aug 28, 2023 · 2 comments · Fixed by #1198
Assignees

Comments

@alexggh
Copy link
Contributor

alexggh commented Aug 28, 2023

The latest image generated from polkadot-sdk fails to start, with the following error.

2023-08-28 06:10:49.922  WARN tokio-runtime-worker sc_service::builder: The NetworkStart returned as part of `build_network` has been silently dropped    
Error: 
   0: �[91mWorker binaries could not be found, make sure polkadot was built/installed correctly. If you ran with `cargo run`, please run `cargo build` first. Searched given workers path (None), polkadot binary path ("/usr/local/bin"), and lib path (/usr/lib/polkadot), workers names: None�[0m

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  �[96m                              ⋮ 5 frames hidden ⋮                               �[0m
   6: �[32m<core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual�[0m�[90m::h54b47fe641e8279b�[0m
      at �[35m/rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/result.rs�[0m:�[35m2002�[0m
   7: �[91mpolkadot::main�[0m�[90m::h160c30f2b3b82c6d�[0m
      at �[35m/builds/parity/mirrors/polkadot-sdk/polkadot/src/main.rs�[0m:�[35m31�[0m
   8: �[32mcore::ops::function::FnOnce::call_once�[0m�[90m::he5a7271b03047d87�[0m
      at �[35m/rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs�[0m:�[35m250�[0m
  �[96m                              ⋮ 14 frames hidden ⋮                              �[0m

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

Tested with:
https://hub.docker.com/r/paritypr/polkadot-debug/tags?page=1&name=master-48415ce2

FYI @mrcnski maybe you've got an idea what is missing here.

@alexggh
Copy link
Contributor Author

alexggh commented Aug 28, 2023

It seems this from: paritytech/polkadot#7337

diff --git a/scripts/ci/dockerfiles/polkadot_injected_debug.Dockerfile b/scripts/ci/dockerfiles/polkadot_injected_debug.Dockerfile
index 128b802b7a..aebbbdcf1b 100644
--- a/scripts/ci/dockerfiles/polkadot_injected_debug.Dockerfile
+++ b/scripts/ci/dockerfiles/polkadot_injected_debug.Dockerfile
@@ -33,12 +33,14 @@ RUN apt-get update && \
        ln -s /data /polkadot/.local/share/polkadot
 
 # add polkadot binary to docker image
-COPY ./polkadot ./polkadot-*-worker /usr/local/bin
+COPY ./polkadot ./polkadot-execute-worker ./polkadot-prepare-worker /usr/local/bin
 
 USER polkadot
 
 # check if executable works in this container
 RUN /usr/local/bin/polkadot --version
+RUN /usr/local/bin/polkadot-execute-worker --version
+RUN /usr/local/bin/polkadot-prepare-worker --version

Did not get migrated here: https://github.com/paritytech/polkadot-sdk/blob/master/docker/polkadot_injected_debug.Dockerfile#L36, I'm not sure why, but I'll prepare a patch to fix it.

@alexggh
Copy link
Contributor Author

alexggh commented Aug 28, 2023

Attempt at fixing it: #1198

@alexggh alexggh self-assigned this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant