Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Handle Collator Candidate to Invulnerable Path #2782

Closed
joepetrowski opened this issue Jun 25, 2023 · 0 comments · Fixed by #2801
Closed

Handle Collator Candidate to Invulnerable Path #2782

joepetrowski opened this issue Jun 25, 2023 · 0 comments · Fixed by #2801
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.

Comments

@joepetrowski
Copy link
Contributor

joepetrowski commented Jun 25, 2023

When registering as a candidate, Collator Selection ensures that the user is not already invulnerable. However, it is possible that a candidate becomes invulnerable via governance referendum (either within set_invulnerables or add_invulnerable).

When adding an invulnerable, the system should check if they are a candidate, and try to remove them (it may not be possible due to T::MinCandidates, but it should try).

Edit: On further thought, we should reconsider this MinCandidates item. It does not include Invulnerables, but it's there AFAIK to make sure there is always one collator in the set. Invulnerables should fulfill this requirement, so I think that MinCandidates should include Invulnerables and be renamed to MinSetSize.

@joepetrowski joepetrowski added J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant