Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user friendly view of storage data #1414

Merged
merged 22 commits into from
Jan 9, 2024
Merged

Add user friendly view of storage data #1414

merged 22 commits into from
Jan 9, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Nov 29, 2023 •
edited
Loading

Summary

Related #101

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?

Add a user-friendly view of contract storage data in the form of a table

Description

Example output:

Screenshot 2023-12-11 at 10 54 09

Screenshot 2023-12-11 at 11 09 09

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed marked this pull request as ready for review December 15, 2023 14:00
ascjones
ascjones reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP review, will finish when I return from Christmas!

crates/cargo-contract/src/cmd/storage.rs Outdated Show resolved Hide resolved
crates/extrinsics/src/contract_storage.rs Show resolved Hide resolved
ascjones
ascjones reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. contract_storage.rs is starting to be quite a large file, so might benefit from breaking up files for different concerns e.g. fetching vs displaying the data.

crates/extrinsics/src/contract_storage.rs Outdated Show resolved Hide resolved
crates/extrinsics/src/contract_storage.rs Outdated Show resolved Hide resolved
crates/extrinsics/src/contract_storage.rs Outdated Show resolved Hide resolved
crates/transcode/src/decode.rs Outdated Show resolved Hide resolved
ascjones
ascjones approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add to CHANGELOG please?

@smiasojed smiasojed merged commit 1990746 into master Jan 9, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/storage branch January 9, 2024 15:09
@smiasojed smiasojed mentioned this pull request Feb 8, 2024
Merged
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiasojed @ascjones