Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subxt and substrate dependencies #1149

Merged
merged 14 commits into from
Jun 23, 2023
Merged

Update subxt and substrate dependencies #1149

merged 14 commits into from
Jun 23, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jun 6, 2023

@ascjones
Copy link
Collaborator Author

ascjones commented Jun 8, 2023

Depends on new substrate-contracts-node release paritytech/substrate-contracts-node#192

Blocked on updating substrate-contracts-node to polkadot-v0.9.43, which in fact contains the updated ContractResult<R, Balance, EventRecord> with the EventRecord parameter type.

@ascjones ascjones marked this pull request as ready for review June 22, 2023 11:01
ascjones added a commit to paritytech/substrate-contracts-node that referenced this pull request Jun 22, 2023
@ascjones ascjones merged commit 6304a68 into master Jun 23, 2023
10 checks passed
@ascjones ascjones deleted the aj/update-subxt branch June 23, 2023 10:46
@JoshOrndorff
Copy link

JoshOrndorff commented Jun 28, 2023

I see that the contracts_runtime.scale file changed in this PR. How often does that happen? And how to you generate that file?

If I want to make cargo contract work with my chain that uses AccountId20 do I need to generate a similar file from my own runtime?

I've also asked about this in https://substrate.stackexchange.com/q/9055/372

EDIT: I've at least figured out how to generate the file now from https://docs.rs/subxt/0.29.0/subxt/attr.subxt.html#metadata

I'm still not totally clear on when and whether i need to regenerate it, but I'm experimenting now. My guess is that AccountId is a sufficiently important change that I'll need to regenerate it.

This was referenced Jul 26, 2023
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pallet contracts primitives with new generic
3 participants