-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fast glob #1650
Use fast glob #1650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of the util and just require is-glob
and fast-glob
directly?
src/utils/glob.js
Outdated
|
||
exports.isGlob = function(filename) { | ||
return isGlob(filename, { | ||
strict: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like strict is the default: https://github.com/micromatch/is-glob/blob/master/index.js#L24
Removed the util and used the libs directly |
Adds a performance boost to the usage of globs