Circuit dynamic configure #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeranged3v
commented
Jul 19, 2023
freeranged3v
commented
Jul 19, 2023
| @@ -470,14 +470,34 @@ pub trait Circuit<F: Field> { | |||
| /// `Circuit` trait because its behaviour is circuit-critical. | |||
| type FloorPlanner: FloorPlanner; | |||
|
|
|||
| /// Runtime parameters to configure the circuit. | |||
| #[cfg(feature = "circuit-params")] | |||
| type Params: Default = (); | |||
There was a problem hiding this comment.
Associated type default: rust-lang/rust#29661
There was a problem hiding this comment.
@parazyd Would turning on this unstable feature - associated type default - be a good idea?
I think tradeoff is:
the pro:
- won't break any circuits implementing the Circuit trait from zcash/halo2, which seems nice, one can use zcash/halo2
Circuitimplementing circuits with this fork directly
the cons:
- potential corner cases (though the usage is simple here)
- need to migrate if and when Rust team introduces a breaking change (but the alternative is breaking the circuits now)
other misc points:
- Using an unstable feature requires depending on
nightlywhich we already do in CI, so I think it isn't an issue.
freeranged3v
commented
Jul 19, 2023
|
|
||
| impl<F: Field> Circuit<F> for MyCircuit { | ||
| type Config = (); | ||
| impl Circuit<pallas::Base> for MyCircuit { |
There was a problem hiding this comment.
Test case that should be helpful to see the flow.
added 8 commits
July 19, 2023 23:18
freeranged3v
force-pushed
the
circuit_dynamic_configure
branch
from
d402d6b
to
478ff44
Compare
freeranged3v
commented
Jul 19, 2023
| @@ -54,7 +54,7 @@ blake2b_simd = "1" | |||
| maybe-rayon = {version = "0.1.0", default-features = false} | |||
|
|
|||
| # Developer tooling dependencies | |||
| plotters = { version = "0.3.0", default-features = false, optional = true } | |||
| plotters = { version = "0.3.0", optional = true } | |||
There was a problem hiding this comment.
I turned on the default features to generate a test circuit layout, the PSE fork has the defaults on too.
|
Thanks a lot. I'll merge this manually and add a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit: privacy-scaling-explorations#168