Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use JSON.stringify for JS result #71

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: use JSON.stringify for JS result #71

merged 1 commit into from
Mar 12, 2024

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Mar 12, 2024

closes #69

closes paradigmxyz/reth#7083

use builtin JSON.stringify when formatting the result, boa.to_json uses all properties

DaniPopes
DaniPopes approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely disgusting that we have to do this

@mattsse mattsse merged commit d7317c7 into main Mar 12, 2024
11 checks passed
@DaniPopes DaniPopes deleted the matt/use-JSON.stringify branch March 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native JS BigInt type for proper serialization debug_traceTransaction custom EVM tracer - ETH value of calls
2 participants
@mattsse @DaniPopes