Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add from_flat_call_config #203

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

0xkrane
Copy link
Contributor

@0xkrane 0xkrane commented Sep 22, 2024

For use and uniformity wrt paradigmxyz/reth#10991

Simple tests included

I could do the PR without this but seems correct to maintain uniformity instead of modifying the TracingInspector in ad hoc ways

@0xkrane 0xkrane changed the title chore: add flat_call_config chore: add from_flat_call_config Sep 22, 2024
@mattsse mattsse added the enhancement New feature or request label Sep 23, 2024
@mattsse
Copy link
Contributor

mattsse commented Sep 23, 2024

we might need some helper function for the parity error setting, but lets ignore this for now in paradigmxyz/reth#10991

@mattsse mattsse merged commit 8ca0160 into paradigmxyz:main Sep 23, 2024
11 checks passed
@0xkrane
Copy link
Contributor Author

0xkrane commented Sep 23, 2024

yeah was going to comment on the main PR, will take that up after

lwedge99 pushed a commit to sentioxyz/revm-inspectors that referenced this pull request Oct 8, 2024
For use and uniformity wrt
paradigmxyz/reth#10991

Simple tests included

I could do the PR without this but seems correct to maintain uniformity
instead of modifying the `TracingInspector` in ad hoc ways

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants