fix(tracing): align trace output with geth #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Sep 14, 2024
Comment on lines
+143
to
+146
| InstructionResult::InvalidFEOpcode => { | ||
| if kind.is_parity() { "Bad instruction" } else { "invalid opcode: INVALID" } | ||
| .to_string() | ||
| } |
There was a problem hiding this comment.
ah I overlooked that there's an additional map:
lwedge99
pushed a commit
to sentioxyz/revm-inspectors
that referenced
this pull request
Oct 8, 2024
1. The error msg should not be converted to parity style in `callTracer`. They should only be converted in `flatCallTracer` which is not supported by reth now. 2. The `gasUsed` should be the `gasLimit` when there's a not reverted error. 3. The `call_frame.to` should be None if the call type is `Create/Create2` and it failed. Related geth code: * https://github.com/ethereum/go-ethereum/blob/a9523b6428238a762e1a1e55e46ead47630c3a23/eth/tracers/native/call_flat.go#L226 * https://github.com/ethereum/go-ethereum/blob/a9523b6428238a762e1a1e55e46ead47630c3a23/core/vm/evm.go#L254 * https://github.com/ethereum/go-ethereum/blob/a9523b6428238a762e1a1e55e46ead47630c3a23/eth/tracers/native/call.go#L88 --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callTracer. They should only be converted inflatCallTracerwhich is not supported by reth now.gasUsedshould be thegasLimitwhen there's a not reverted error.call_frame.toshould be None if the call type isCreate/Create2and it failed.Related geth code: