Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index out of bound when resetting TracingInspector #115

Merged
merged 2 commits into from
May 12, 2024
Merged

Fix index out of bound when resetting TracingInspector #115

merged 2 commits into from
May 12, 2024

Conversation

Ebolon
Copy link
Contributor

@Ebolon Ebolon commented May 11, 2024

Fixes out of bound error when using fuse() in TracingInspector.

Error before:

index out of bounds: the len is 0 but the index is 0
panicked at src/tracing/arena.rs:54:31:

Cause: CallTraceArena is initialized using default() but when calling clear() the default root node is removed.

mattsse
mattsse approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find.

I kept using clear, but pushed the empty node.

@mattsse mattsse merged commit 7fc34a2 into paradigmxyz:main May 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ebolon @mattsse