Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use with_chain_id for CfgEnv #7815

Closed
tcoratger opened this issue Apr 23, 2024 · 2 comments · Fixed by #8327
Closed

Use with_chain_id for CfgEnv #7815

tcoratger opened this issue Apr 23, 2024 · 2 comments · Fixed by #8327
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request S-blocked This cannot more forward until something else changes S-stale This issue/PR is stale and will close with no further activity

Comments

@tcoratger
Copy link
Contributor

Describe the feature

After bluealloy/revm#1327 is merged and after the next release of revm, we should replace direct assignment of chain_id in CfgEnv with the with_chain_id method, which offers a cleaner and more expressive approach:

reth/crates/payload/optimism/src/payload.rs

Lines 115 to 116 in 9fd35f9

let mut cfg = CfgEnv::default();
cfg.chain_id = chain_spec.chain().id();

Additional context

No response
@tcoratger tcoratger added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Apr 23, 2024
@onbjerg
Copy link
Member

onbjerg commented Apr 23, 2024

Blocked by #7765

@onbjerg onbjerg added S-blocked This cannot more forward until something else changes C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 15, 2024
@Vid201 Vid201 mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request S-blocked This cannot more forward until something else changes S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use with_chain_id for CfgEnv Vid201/reth
2 participants
@onbjerg @tcoratger