Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collecting storage diffs for block 0 is broken #31

Closed
banteg opened this issue Aug 16, 2023 · 2 comments
Closed

collecting storage diffs for block 0 is broken #31

banteg opened this issue Aug 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@banteg
Copy link
Contributor

banteg commented Aug 16, 2023

Version
cryo 0.2.0

Platform
linux x86_64

Description
I tried this code vs erigon client:

cryo storage_diffs -b 0

from erigon rpcdameon log:

method=trace_replayBlockTransactions
err="block 0000000000000000000000000000000000000000000000000000000000000000 not found"

block 0 should probably be skipped for storage diffs
@banteg banteg added the bug Something isn't working label Aug 16, 2023
@MRabenda
Copy link

I think would be not vise to skip them - as block can have storage changes

@banteg
Copy link
Contributor Author

banteg commented Aug 16, 2023

it only has genesis state. i filed a bug because the method crashes for block 0, so the cryo extraction crashes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@banteg @MRabenda