feat: impl wallet_ namespace
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Oct 4, 2024
onbjerg
force-pushed
the
onbjerg/wallet-rpc-impl
branch
from
886ba01
to
bea5005
Compare
onbjerg
commented
Oct 7, 2024
onbjerg
force-pushed
the
onbjerg/wallet-rpc-impl
branch
7 times, most recently
from
ab376eb
to
5b7da3f
Compare
onbjerg
force-pushed
the
onbjerg/wallet-rpc-impl
branch
from
5b7da3f
to
95220dc
Compare
mattsse
requested changes
Oct 8, 2024
| @@ -80,6 +80,9 @@ reth-chainspec = { git = "https://github.com/paradigmxyz/reth.git", rev = "78426 | |||
| ] } | |||
| reth-cli = { git = "https://github.com/paradigmxyz/reth.git", rev = "7842673" } | |||
| reth-cli-util = { git = "https://github.com/paradigmxyz/reth.git", rev = "7842673" } | |||
| reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth.git", rev = "7842673", features = [ | |||
| "optimism", | |||
There was a problem hiding this comment.
this can be removed with latest reth
onbjerg
force-pushed
the
onbjerg/wallet-rpc-impl
branch
2 times, most recently
from
21a9103
to
9744e59
Compare
mattsse
approved these changes
Oct 8, 2024
onbjerg
force-pushed
the
onbjerg/wallet-rpc-impl
branch
from
9744e59
to
2f26397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
wallet_methods outlined in #126To enable the namespace, an environment variable with a secret key used to sponsor the transactions must be set,
EXP1_SK. Additionally, a comma-delimited list of checksummed addresses for valid delegation contracts must also be provided,EXP1_WHITELIST.Closes #131, closes #132