Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump reth #111

Merged
merged 1 commit into from
Sep 12, 2024
Merged

chore: bump reth #111

merged 1 commit into from
Sep 12, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Sep 10, 2024 •
edited
Loading

There is no longer an optimism feature in the main reth crate, so there is some question of whether this works or not, or if there are some subcrates we now are compiling incorrectly

Additionally, we don't need reth as a dep in the alphanet binary crate anymore. I also moved the optimism feature flags into the workspace root.

@onbjerg onbjerg added the C-enhancement New feature or request label Sep 10, 2024
@onbjerg onbjerg mentioned this pull request Sep 10, 2024
Merged
@onbjerg onbjerg changed the base branch from main to onbjerg/msrv September 10, 2024 13:46
@onbjerg onbjerg force-pushed the onbjerg/bump-reth branch 2 times, most recently from 2e059df to 820bf3c Compare September 10, 2024 13:56
Base automatically changed from onbjerg/msrv to main September 10, 2024 16:59
Rjected
Rjected reviewed Sep 10, 2024
View reviewed changes
bin/alphanet/Cargo.toml Outdated Show resolved Hide resolved
@onbjerg onbjerg force-pushed the onbjerg/bump-reth branch 2 times, most recently from 58d046e to a785a5c Compare September 11, 2024 08:27
mattsse
mattsse requested changes Sep 11, 2024
View reviewed changes
crates/node/Cargo.toml Outdated Show resolved Hide resolved
bin/alphanet/Cargo.toml Outdated Show resolved Hide resolved
@onbjerg onbjerg force-pushed the onbjerg/bump-reth branch 4 times, most recently from fdfc200 to 100a280 Compare September 12, 2024 13:39
@onbjerg onbjerg marked this pull request as ready for review September 12, 2024 13:39
mattsse
mattsse approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

crates/node/src/evm.rs Outdated Show resolved Hide resolved
crates/precompile/Cargo.toml Outdated Show resolved Hide resolved
@onbjerg onbjerg mentioned this pull request Sep 12, 2024
Merged
@onbjerg onbjerg merged commit 9441e6b into main Sep 12, 2024
13 checks passed
@onbjerg onbjerg deleted the onbjerg/bump-reth branch September 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onbjerg @Rjected @mattsse