Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Matplotlib imports in style #58921

Merged
merged 2 commits into from
Jun 4, 2024
Merged

CLN: Matplotlib imports in style #58921

merged 2 commits into from
Jun 4, 2024

Conversation

mroeschke
Copy link
Member

Just using import_optional_dependency where needed.

@mroeschke mroeschke added Visualization plotting Clean Styler conditional formatting using DataFrame.style labels Jun 4, 2024
@mroeschke mroeschke requested a review from attack68 as a code owner June 4, 2024 18:36
@attack68
Copy link
Contributor

attack68 commented Jun 4, 2024

LGTM. Never liked that context manager :)

@mroeschke mroeschke added this to the 3.0 milestone Jun 4, 2024
@mroeschke mroeschke merged commit cc85e2c into pandas-dev:main Jun 4, 2024
53 checks passed
@mroeschke mroeschke deleted the cln/matplotlib/style branch June 4, 2024 19:33
@Dacops Dacops mentioned this pull request Jun 6, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attack68 attack68 attack68 approved these changes

Assignees
No one assigned
Labels
Clean Styler conditional formatting using DataFrame.style Visualization plotting
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @attack68