Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] improving the ExcelWriter docstring #47568

Merged

Conversation

noatamir
Copy link
Member

@noatamir noatamir commented Jul 1, 2022

@noatamir noatamir marked this pull request as ready for review July 1, 2022 13:54
@mroeschke mroeschke added Docs IO Excel read_excel, to_excel and removed Docs labels Jul 1, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 1, 2022
@mroeschke
Copy link
Member

Thanks @noatamir. Mind posting a screenshot of this docstring after the change?

@noatamir
Copy link
Member Author

noatamir commented Jul 1, 2022

Here you go:
Screenshot 2022-07-01 at 19 42 15

@mroeschke mroeschke added the Docs label Jul 1, 2022
@mroeschke mroeschke merged commit 3e9aaf4 into pandas-dev:main Jul 1, 2022
@mroeschke
Copy link
Member

Thanks @noatamir! (Failure unrelated)

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@noatamir noatamir deleted the doc-improve-excel-write-docstring branch October 20, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Malformed list in sphinx output and other problems with "ExcelWriter" doc
2 participants