DEPR: Series/DataFrame/HDFStore.iteritems()

[mroeschke]

• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[jorisvandenbossche]

What's the reasoning to deprecate iteritems()?

I suppose it is the duplication with items()? On the other hand, iteritems() also gives some consistency with iterrows and itertuples, which could be a reason in favor to rather keep iteritems()?

[mroeschke]

The duplication with items() was the motivation.

I think iteritems() was designed to mirror Python's dict API in 2.7, and since that was removed in PY3 I chose to remove iteritems(). (I encountered evidence of this when I tried deprecating Series/DataFrame.keys, and an internal path was flexibly accepting a dict-like API)

[jorisvandenbossche]

when I tried deprecating Series/DataFrame.keys

Do you still have plans to propose that? Or the problems you encountered were sufficient to drop the idea?
(if we would like to deprecate .keys() (I personally never use it), that would be another reason to keep iteritems(), I would say)

[mroeschke]

Yeah it was tricky to deprecate keys() since:

In [3]: pd.core.dtypes.inference.is_dict_like(Series([1]))
Out[3]: True

In [4]: pd.core.dtypes.inference.is_dict_like(DataFrame([1]))
Out[4]: True

in which keys is an attribute is_dict_like checks. So it may be API breaking / a lot of effort if keys were deprecated.

[jreback]

-1 on interitems this deprecated in python itself