Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use float arange when required or intended #35477

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

bashtage
Copy link
Contributor

Ensure arange is float when intened or required by NumPy

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@bashtage
Copy link
Contributor Author

Use float initialization to allow NaN to be set of when setting floating points later.

@bashtage
Copy link
Contributor Author

Used to be part of #35427, but split it out to have one PR one issue. Required by Future NumPy.

Ensure arange is float when intened or required by NumPy
@bashtage
Copy link
Contributor Author

Fixes about 12 of the np-dev fails.

@WillAyd WillAyd added the Clean label Jul 30, 2020
@WillAyd WillAyd added this to the 1.2 milestone Jul 30, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite Compat pandas objects compatability with Numpy or Python functions labels Jul 30, 2020
@simonjayhawkins simonjayhawkins merged commit bdcc5bf into pandas-dev:master Jul 30, 2020
@simonjayhawkins
Copy link
Member

Thanks @bashtage

@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 1, 2020
simonjayhawkins pushed a commit that referenced this pull request Aug 1, 2020
…#35500)

Co-authored-by: Kevin Sheppard <bashtage@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants