BUG Fix for Add numeric_only to function signature of DataFrameGroupBy.cumprod and `DataFrameGroupBy.cumsum #59427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I have made changes to include 'numeric_only' flag in the function parameters as described in the issue description scope. Please let me know if we need to also have 'skipna' in the function parameters and remove *args and **kwargs entirely. Thank you! |
mroeschke
reviewed
Aug 6, 2024
mroeschke
reviewed
Aug 6, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Aug 6, 2024
|
Thanks @maushumee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric_onlyto function signature ofDataFrameGroupBy.cumprodand `DataFrameGroupBy.cumsum#53071doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.