Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat: PandasArray not accepted by many pandas functions #25018

Closed
4 tasks
jbrockmendel opened this issue Jan 30, 2019 · 1 comment
Closed
4 tasks

compat: PandasArray not accepted by many pandas functions #25018

jbrockmendel opened this issue Jan 30, 2019 · 1 comment
Labels
Compat pandas objects compatability with Numpy or Python functions Internals Related to non-user accessible pandas implementation

Comments

@jbrockmendel
Copy link
Member

In #24990 there was a brief discussion about backing Blocks with PandasArray objects. In an experimental local branch I'm trying this and finding a handful of rough edges that can be smoothed out. I'll update this list as I find more

  • view method and size property
  • dtypes.cast.astype_nansafe breaks on PandasArray
  • assert PandasDtype('object') == np.object fails
  • is_dtype_equal(dtype, dtype) returns False for PandasDtype objects
@gfyoung gfyoung added Internals Related to non-user accessible pandas implementation Compat pandas objects compatability with Numpy or Python functions labels Feb 2, 2019
@jbrockmendel jbrockmendel mentioned this issue Jun 18, 2019
Closed
@jbrockmendel
Copy link
Member Author

On further reflection, I would rather nanops retain the tighter typing. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @gfyoung