tests: properly teardown connections

pallets-eco · Oct 24, 2024 · 24cdf52 · 24cdf52
1 parent 6fbcdcc
commit 24cdf52
Showing 1 changed file with 27 additions and 12 deletions.
diff --git a/tests/test_main.py b/tests/test_main.py
@@ -94,11 +94,14 @@ def _fill(self, sess):
 
 class QuerySelectFieldTest(TestBase):
     def setUp(self):
-        engine = create_engine("sqlite:///:memory:", echo=False)
-        self.Session = sessionmaker(bind=engine)
+        self.engine = create_engine("sqlite:///:memory:", echo=False)
+        self.Session = sessionmaker(bind=self.engine)
         from sqlalchemy.orm import mapper
 
-        self._do_tables(mapper, engine)
+        self._do_tables(mapper, self.engine)
+
+    def tearDown(self):
+        self.engine.dispose()
 
     def test_without_factory(self):
         sess = self.Session()
@@ -239,12 +242,16 @@ class QuerySelectMultipleFieldTest(TestBase):
     def setUp(self):
         from sqlalchemy.orm import mapper
 
-        engine = create_engine("sqlite:///:memory:", echo=False)
-        Session = sessionmaker(bind=engine)
-        self._do_tables(mapper, engine)
+        self.engine = create_engine("sqlite:///:memory:", echo=False)
+        Session = sessionmaker(bind=self.engine)
+        self._do_tables(mapper, self.engine)
         self.sess = Session()
         self._fill(self.sess)
 
+    def tearDown(self):
+        self.sess.close()
+        self.engine.dispose()
+
     class F(Form):
         a = QuerySelectMultipleField(get_label="name", widget=LazySelect())
 
@@ -343,12 +350,16 @@ class Student(Model):
         self.Student = Student
         self.Course = Course
 
-        engine = create_engine("sqlite:///:memory:", echo=False)
-        Session = sessionmaker(bind=engine)
+        self.engine = create_engine("sqlite:///:memory:", echo=False)
+        Session = sessionmaker(bind=self.engine)
         self.metadata = Model.metadata
-        self.metadata.create_all(bind=engine)
+        self.metadata.create_all(bind=self.engine)
         self.sess = Session()
 
+    def tearDown(self):
+        self.sess.close()
+        self.engine.dispose()
+
     def test_auto_validators(self):
         course_form = model_form(self.Course, self.sess)()
         student_form = model_form(self.Student, self.sess)()
@@ -449,12 +460,16 @@ class StudentDefaultScoreScalar(Model):
         self.StudentDefaultScoreCallable = StudentDefaultScoreCallable
         self.StudentDefaultScoreScalar = StudentDefaultScoreScalar
 
-        engine = create_engine("sqlite:///:memory:", echo=False)
-        Session = sessionmaker(bind=engine)
+        self.engine = create_engine("sqlite:///:memory:", echo=False)
+        Session = sessionmaker(bind=self.engine)
         self.metadata = Model.metadata
-        self.metadata.create_all(bind=engine)
+        self.metadata.create_all(bind=self.engine)
         self.sess = Session()
 
+    def tearDown(self):
+        self.sess.close()
+        self.engine.dispose()
+
     def test_column_default_callable(self):
         student_form = model_form(self.StudentDefaultScoreCallable, self.sess)()
         self.assertEqual(student_form._fields["score"].default, 5)