Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portal to use React 16 Portals for simpler unit testing with Enzyme. #1860

Closed
UselessPickles opened this issue Dec 3, 2017 · 4 comments
Closed

Update Portal to use React 16 Portals for simpler unit testing with Enzyme. #1860

UselessPickles opened this issue Dec 3, 2017 · 4 comments
Assignees
@adidahiya
Labels
Package: core Type: breaking change
Milestone
2.0.0

Comments

@UselessPickles
Copy link
Contributor

Enzyme has been updated to support React 16 Portals.

React 16 Portals: https://reactjs.org/docs/portals.html
Relevant Enzyme issue: enzymejs/enzyme#1150
Relevant Enzyme pull request: enzymejs/enzyme#1345

If Blueprint.Portal was updated to make use of ReactDOM.createPortal, then components involving Blueprint.Portals would be much easier to unit test via Enzyme, because Enzyme's wrapper methods (find, etc.) are now able to work across portal boundaries.

It may even simplify the implementation of Blueprint.Portal.
@UselessPickles UselessPickles mentioned this issue Dec 3, 2017
Closed
@giladgray
Copy link
Contributor

this will likely happen in 2.0, coming very soon!

@giladgray giladgray added this to the 2.0.0 milestone Dec 6, 2017
@kudigaracoder
Copy link

2.0? 😃 By end of the year?

@cmslewis
Copy link
Contributor

cmslewis commented Dec 6, 2017

@kudigaracoder That's the goal, yep.

@giladgray giladgray assigned adidahiya and unassigned adidahiya Dec 11, 2017
@adidahiya adidahiya mentioned this issue Dec 11, 2017
Merged
@kudigaracoder
Copy link

Good luck with the 2.0 update guys! Are you introducing new components?(that's not part of Labs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
Package: core Type: breaking change
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
5 participants
@cmslewis @giladgray @adidahiya @kudigaracoder @UselessPickles