Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: specify log data #36

Open
sunfish opened this issue Jun 15, 2020 · 6 comments
Open

Feature request: specify log data #36

sunfish opened this issue Jun 15, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@sunfish
Copy link

sunfish commented Jun 15, 2020

Many thanks for this smart and useful extension.
it would be a helpful feature if the identifiers of the form fields could be specified, which are then stored in the column tx_formlog_entries.data.

I can imagine it like this:

identifier: LogFormData
options:
  logDataIdentifiers:
    - firstname
    - lastname
    - email

I would be very happy if the feature would be realized. If necessary I can offer support for the implementation.

@mbrodala
Copy link
Member

That would basically mean filtering the form values before storing them which shouldn't be that hard.

What is your usecase exactly?

@sunfish
Copy link
Author

sunfish commented Jun 15, 2020 via email

@mbrodala
Copy link
Member

@sunfish Would you create a PR for this? You could basically copy the current logic for finisherVariables, but if undefined we'd need to collect all form values just like before.

Also I'd suggest elementIdentifiers or identifiers as option name.

@sabbelasichon
Copy link
Contributor

@mbrodala Would like to implement this feature. But waiting for #59

@mbrodala mbrodala added the enhancement New feature or request label Feb 18, 2022
@mbrodala
Copy link
Member

@sabbelasichon The mentioned issue was finished, can you have another look?

@DavRet
Copy link

DavRet commented Mar 6, 2023

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants