BUG: Incorrect image paths

[VincentTam]

Bug Report

Describe the bug

I tried building a demo site for this theme on Framagit: https://vincenttam.frama.io/fish-demo/blog/creating-a-new-theme/ with

baseurl = "https://vincenttam.frama.io/fish-demo/"

in config.toml. However, the images aren't rendered. Rendered HTML shows

<article class="mini-post">
      <section>
        
<a href="/fish-demo/blog/hugoisforlovers/" class="image featured">
  <img src="/img/2014/04/pic01.jpg" alt="Pic 1">
</a>


      </section>
      <header>
        <h1><a href="/fish-demo/blog/hugoisforlovers/">Getting Started with Hugo</a></h1>
        <time class="published" datetime="">April 2, 2014</time>
      </header>
    </article>

The src of the <img> is incorrect in case of GitHub/GitLab project pages. I'm not an expert in web design/development. You're going to be more proficient than me to fix this.

hugo-future-imperfect-slim/layouts/post/featured.html

Lines 1 to 5 in e0eb982

	{{ if .Params.featured }}
	<a href="{{ .RelPermalink }}" class="image featured">
	<img src="/img/{{ if eq .Params.featuredpath "date" }}{{ .Page.Date.Format "2006/01" }}/{{ else }}{{ .Params.featuredpath }}{{ end }}{{ .Params.featured }}" alt="{{ .Params.featuredalt }}">
	</a>
	{{ end }}

Besides, I also get error on nav bar and page redirect after submitting Staticman comment. The images in the posts have incorrect URL's.

To Reproduce

1. Use this theme on a GitHub/GitLab project pages
2. See broken images

Expected behavior

Screenshots

Environment

• Hugo Version: 0.55.6
• Browser and Version: Firefox 67.0.4 (64-bit)
• Platform: Desktop
• Link to Project: https://framagit.org/VincentTam/fish-demo

[pacollins]

That is an interesting bug I will have to look into. It is due to the URL being relative for multilingual, so I think Hugo might be parsing it odd? I'll check back.

[VincentTam]

Thanks for reply. I should have said that the contents of the demo site are copied from exampleSite by

cp -r exampleSite/* LICENSE.md .

[pacollins]

On mobile, so I'm not certain on this, but I think this should solve it. It probably does not need the parenthesis around the path.Join, but I played it safe.

<img src="{{ (path.Join "img" (cond (eq .Params.featuredpath "date") (.Page.Date.Format "2006/01") (.Params.featuredpath)) .Params.featured) | relurl }}" alt="{{ .Params.featuredalt }}">

https://gohugo.io/functions/relurl/