Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

BUG: Documentation missing on fancybox shortcode #110

Closed
twatzl opened this issue Feb 3, 2020 · 1 comment
Closed

BUG: Documentation missing on fancybox shortcode #110

twatzl opened this issue Feb 3, 2020 · 1 comment

Comments

@twatzl
Copy link
Contributor

twatzl commented Feb 3, 2020

Hi,
I am using this theme since about 4 months, but I just found out that there is a shortcode for fancybox. I found this out only by looking at the original repo https://github.com/pacollins/hugo-future-imperfect
and by looking in the code.

I think it might be useful to either use the same documentation in readme.md or to get rid of the shortcode if it no longer works.

Also the paragraph about the original theme could be clearer. When considering the following sentence:

This version takes that port and modernizes it with CSS Grid and Modern Hugo functions. In addition to the features that were present in the original theme, there are some additional features for you to utlize however you see fit.

The question which is still remaining after this paragraph is what features are you talking about. Is it just the CSS grid and modern hugo functions or are there more differences than that.

@pacollins
Copy link
Owner

See #84 about documentation. There are additional features that have yet to be reported to the slimmed theme.

FancyBox is a feature, just not in the documentation. It is documented within the short code file. See below:

<!--
Inside Double Brackets:
fancybox path="path" file="file" caption="caption" gallery="gallery"
fancybox "path" "file" "caption" "gallery"
# of Params: 2-4
Positional or Named
position 0, name: path
Can pass in the following values:
title: will use /img/LinkTitle as the path
date: will use /img/Year/Month as the path
/path/to/img: can pass in explicit path to the image
position 1, name: file
Name of the file including the file extension
position 2, name: caption
Text for the caption of the image
position 3, name: gallery
Name of the gallery the image should be included in
-->

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants